[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-31 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith closed this revision. rsmith added a comment. Committed as r317032, thanks! https://reviews.llvm.org/D36101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-31 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 120977. Rakete added a comment. Added some more tests. If this patch is still ok can you please commit it @rsmith ? Thanks! https://reviews.llvm.org/D36101 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expre

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-31 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 120966. Rakete added a comment. Used Parser's `GreaterThanIsOperator` just to be sure. :) https://reviews.llvm.org/D36101 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index: test/Parser/cx

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lib/Parse/ParseExpr.cpp:273 static bool isFoldOperator(tok::TokenKind Kind) { - return isFoldOperator(getBinOpPrecedence(Kind, false, true)); + return

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-21 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 119767. Rakete added a comment. Used the naming convention of LLVM + friendly ping. :) https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index: test/Parser/cxx1z-fold-expressions.cpp =

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-09-19 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 115846. Rakete added a comment. Used the correct return type, even if it doesn't really matter to the compiler. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index: test/Parser/cxx1z-fold-

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-09-19 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 115842. Rakete added a project: clang. Rakete added a comment. Added the tests to the existing test file for fold operators that I didn't notice before :) https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-08-28 Thread Blitz Rakete via Phabricator via cfe-commits
Rakete updated this revision to Diff 113020. Rakete added a comment. Updated test to use the -std=c++17 option + friendly ping https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp Index: test/CXX/expr/expr.prim/expr.prim.fold

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-08-08 Thread Blitz Rakete via Phabricator via cfe-commits
Rakete added a comment. Ping? https://reviews.llvm.org/D36101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-07-31 Thread Blitz Rakete via Phabricator via cfe-commits
Rakete created this revision. The right shift operator was not seen as a valid operator in a fold expression, which is PR32563. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp Index: test/CXX/expr/expr.prim/expr.prim.fold/p