This revision was automatically updated to reflect the committed changes.
Closed by commit rL311284: [clang-diff] Fix similarity computation (authored by
krobelus).
Changed prior to commit:
https://reviews.llvm.org/D36185?vs=110951&id=111877#toc
Repository:
rL LLVM
https://reviews.llvm.org/
johannes updated this revision to Diff 110951.
johannes added a comment.
comment getJaccardSimilarity
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
tes
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:738
+ }
+ double Denominator = T1.getNumberOfDescendants(Id1) - 1 +
+ T2.getNumberOfDescendants(
johannes updated this revision to Diff 110688.
johannes added a comment.
newline in error message
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
test/To
arphaman added inline comments.
Comment at: tools/clang-diff/ClangDiff.cpp:436
+else if (StopAfter != "bottomup") {
+ llvm::errs() << "Error: Invalid argument for -stop-after";
+ return 1;
Add a newline to the string as well.
https://reviews.llvm.
johannes updated this revision to Diff 109505.
johannes added a comment.
merge parent changes
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
test/Toolin
johannes added inline comments.
Comment at: test/Tooling/clang-diff-bottomup.cpp:3
+// RUN: %clang_cc1 -E %s > %t.dst.cpp -DDEST
+// RUN: clang-diff -m -no-compilation-database -s=0 %t.src.cpp %t.dst.cpp |
FileCheck %s
+//
klimek wrote:
> Instead of using -no-co
johannes updated this revision to Diff 109424.
johannes added a comment.
add test for Options.MaxSize
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
tes
