atanasyan added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5979-5981
+if (S.Context.getTargetInfo().getABI() != "o32")
+ S.Diag(Attr.getLoc(), diag::err_attribute_supported_by_o32)
+ << Attr.getName() << D->getLocation();
aaron.ballm
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#829006, @sdardis wrote:
> @aaron.ballman I missed your first comments when I'd submitted mine.
>
> In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
>
sdardis added a comment.
@aaron.ballman I missed your first comments when I'd submitted mine.
In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote:
> In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
>
> > I think for the interrupt attribute, it should be an error. Currently
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
> I think for the interrupt attribute, it should be an error. Currently it's an
> implementation detail that it errors out in the backend but in principal it
> can be supported (I haven't gotten around to
sdardis added a comment.
I think for the interrupt attribute, it should be an error. Currently it's an
implementation detail that it errors out in the backend but in principal it can
be supported (I haven't gotten around to addressing it.)
For the micromips attribute, I believe it should be an
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#828881, @atanasyan wrote:
> In https://reviews.llvm.org/D36208#828853, @sdardis wrote:
>
> > Currently there is no support in the backend for the interrupt attribute
> > for mips64 / using N32 & N64 abis, it will give a fatal erro
atanasyan added a comment.
In https://reviews.llvm.org/D36208#828853, @sdardis wrote:
> Currently there is no support in the backend for the interrupt attribute for
> mips64 / using N32 & N64 abis, it will give a fatal error. Previously the
> backend lacked support for the static relocation mod
sdardis added a comment.
Some comments:
Currently there is no support in the backend for the interrupt attribute for
mips64 / using N32 & N64 abis, it will give a fatal error. Previously the
backend lacked support for the static relocation model which is an expected
requirement for interrupt h
atanasyan created this revision.
atanasyan added a project: clang.
Herald added a subscriber: arichardson.
This change enables `long_call/short_call/far/near`, `micromips`, and
`interrupt` attributes on MIPS64 targets. In case of using the `mips16`
attribute with any ABI except `O32` compiler sh
