Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread David Blaikie via cfe-commits
OK - go ahead and remove the tests then, if the functionality is now covered by the buildbot+existing tests. On Wed, Aug 9, 2017 at 12:04 PM Grang, Mandeep Singh wrote: > > Ah, OK. I'm still curious about whether this results in a loss of test > coverage. Without this

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread Grang, Mandeep Singh via cfe-commits
> Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test, would the bug it was testing still be caught by some test failure in at least one of the forward or reverse iteration modes? Sorry ... I missed that. Yes, the reverse iteration buildbot

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread David Blaikie via cfe-commits
On Wed, Aug 9, 2017 at 1:44 AM Grang, Mandeep Singh wrote: > In D35043 I have removed the llvm tests which use -reverse-iterate. This > patch removes the clang tests. > Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test,

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread Grang, Mandeep Singh via cfe-commits
In D35043 I have removed the llvm tests which use -reverse-iterate. This patch removes the clang tests. Should I post a later patch to change all "class PointerLikeTypeTraits" to "struct PointerLikeTypeTraits"? On 8/7/2017 2:50 PM, David Blaikie wrote: On Mon, Aug 7, 2017 at 12:08 PM

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-07 Thread David Blaikie via cfe-commits
On Mon, Aug 7, 2017 at 12:08 PM Mandeep Singh Grang via Phabricator < revi...@reviews.llvm.org> wrote: > mgrang added a comment. > > This patch does 3 things: > > 1. Get rid of the unit test objc-modern-metadata-visibility2.mm because > this test check uses flag -reverse-iterate. This flag will

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-07 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. This patch does 3 things: 1. Get rid of the unit test objc-modern-metadata-visibility2.mm because this test check uses flag -reverse-iterate. This flag will be removed in https://reviews.llvm.org/D35043. 2. https://reviews.llvm.org/D35043 gets rid of the empty base

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-07 Thread David Blaikie via cfe-commits
Not sure I understand the context for these changes - could you describe the motivation(s) in more detail? On Sun, Aug 6, 2017 at 10:39 PM Mandeep Singh Grang via Phabricator < revi...@reviews.llvm.org> wrote: > mgrang created this revision. > > This patch is in response to

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-06 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. This patch is in response to https://reviews.llvm.org/D35043 which removed -reverse-iterate flag and the base definition for PointerLikeTypeTrait. https://reviews.llvm.org/D36386 Files: include/clang/AST/ExternalASTSource.h