[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

dcoughlin added a comment. I'm a bit surprised that this is needed for unit tests. Aren't unit tests supposed to clean up their own state? Leaking a scarce resource in one unit test can cause another unit test to fail, which can be hard to track down. Or is this for deliberately testing a scena

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch adds "mx_create_sink" annotation support to MagentaHandleChecker to address the false positives found in Magenta unit tests. After this patch, when a call to a function contains this annotation, MagentaHandleChecker w