This revision was automatically updated to reflect the committed changes.
Closed by commit rL310613: [mips] Notify user that `-mabicalls` is ignored on
non-PIC N64 ABI (authored by atanasyan).
Changed prior to commit:
https://reviews.llvm.org/D36550?vs=110561=110585#toc
Repository:
rL LLVM
sdardis added a comment.
Nit: my comment on line 297, "non position-independent code and N64 ABI"
should be "non position-independent code and the N64 ABI".
LGTM otherwise.
Repository:
rL LLVM
https://reviews.llvm.org/D36550
___
cfe-commits
atanasyan updated this revision to Diff 110561.
atanasyan edited the summary of this revision.
atanasyan added a comment.
- Addressed review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D36550
Files:
include/clang/Basic/DiagnosticDriverKinds.td
sdardis added a comment.
Slight tweak to the summary:
> The -mabicalls option does not have a sense in case of non position
> independent code on N64 ABI. After this change driver starts to show a
> warning that -mabicalls is ignored in that case.
The -mabicalls option does not make sense in
atanasyan created this revision.
atanasyan added a project: clang.
Herald added a subscriber: arichardson.
The `-mabicalls` option does not have a sense in case of non position
independent code on N64 ABI. After this change driver starts to show a warning
that `-mabicalls` is ignored in that
