[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

This revision was automatically updated to reflect the committed changes. Closed by commit rL310614: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36551?vs=110562=110586#toc Repository:

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > atanasyan wrote: >

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > Can you put this in

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s Can you put this in

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan updated this revision to Diff 110562. atanasyan added a comment. - Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D36551 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp test/Driver/mips-features.c

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:296-297 +def warn_drv_unsupported_longcalls : Warning< + "ignoring '-mlong-calls' option as it cannot be used with " + "%select{|the implicit usage of }0-mabicalls">, + InGroup;

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan created this revision. atanasyan added a project: clang. Herald added a subscriber: arichardson. While we do not support `-mshared / -mno-shared` properly, show warning and ignore `-mlong-calls` option in case of implicitly or explicitly provided `-mabicalls` option. The patch