spyffe abandoned this revision.
spyffe marked 13 inline comments as done.
spyffe added a comment.
At @bruno 's request, abandoning this revision in favor of the updated
https://reviews.llvm.org/D38208.
That revision has all the changes requested.
https://reviews.llvm.org/D36589
bruno added a comment.
Thanks for the additional docs! More comments below.
Comment at: lib/AST/ExternalASTMerger.cpp:116
+if (auto *ToDC = dyn_cast(To)) {
+ logs() << "(ExternalASTMerger*)" << (void*)
+ << " imported (DeclContext*)" << (void*)ToDC
spyffe updated this revision to Diff 116405.
spyffe marked 18 inline comments as done.
spyffe added a subscriber: cfe-commits.
spyffe added a comment.
Updated to reflect Bruno's suggestions.
- Commented `ExternalASTMerger.h` extensively.
- Refactored the log into a pluggable `raw_ostream` that
