[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread don hinton via Phabricator via cfe-commits
hintonda added a comment. > I'd avoid such extra complexity, after all this is just an example. Understood... LGTM > BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info --show-item revision" Guess my new macbook pro spoiled me... https://reviews.llvm.org/D36635

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. I'd avoid such extra complexity, after all this is just an example. One can force the full rebuild with --no-cache. It'll take just a bit more time since most of the time is consumed by the compiler builds. BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread don hinton via Phabricator via cfe-commits
hintonda added a comment. You may want to add an ARG statement to force docker to rerun the svn commands each time you invoke `docker build`. Otherwise it will reuse the cache since docker only looks at the RUN text, not it's result. To get around that, you can add an `ARG REVISION`

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added inline comments. Comment at: tools/clang-fuzzer/Dockerfile:22 +# Get LLVM +RUN svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm +RUN cd llvm/tools && svn co http://llvm.org/svn/llvm-project/cfe/trunk clang -r $(cd ../ && svn info | grep Revision | awk '{print

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc updated this revision to Diff 110810. kcc added a comment. fix 'svn co' command (apparently it did not matter though) https://reviews.llvm.org/D36635 Files: tools/clang-fuzzer/Dockerfile tools/clang-fuzzer/README.txt Index: tools/clang-fuzzer/README.txt

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: tools/clang-fuzzer/Dockerfile:22 +# Get LLVM +RUN svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm +RUN cd llvm/tools && svn co http://llvm.org/svn/llvm-project/cfe/trunk clang -r $(cd ../ && svn info | grep Revision | awk

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

2017-08-11 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc created this revision. Add a Dockerfile for clang-proto-fuzzer https://reviews.llvm.org/D36635 Files: tools/clang-fuzzer/Dockerfile tools/clang-fuzzer/README.txt Index: tools/clang-fuzzer/README.txt === ---