erichkeane added a comment.
Of course, overnight I realized I am probably better off having the
'CpuSupports' validate MULTIPLE features at a time! I'll update this patch
with an improvement when I get one that I think is really useful. Sorry for
the thrash.
https://reviews.llvm.org/D36707
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
erichkeane planned changes to this revision.
erichkeane added a comment.
I actually updated it a bit since then, so I'll hold off on committing until my
replacement version is perfect, I'd prefer to stop churning. Thanks for the
review though Craig!
https://reviews.llvm.org/D36707
erichkeane updated this revision to Diff 113291.
erichkeane added a comment.
This revision is now accepted and ready to land.
I figured out that combining the CpuSupports items via an array is a REALLY
useful function for dispatch. I've got most of gcc's target implemented, so I
believe that th
erichkeane updated this revision to Diff 113297.
erichkeane added a comment.
Woops, messed up my rebase!
https://reviews.llvm.org/D36707
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
=
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7414
+ StringRef FeatureStr = cast(FeatureExpr)->getString();
+ return EmitX86CpuSupports({FeatureStr});
+}
You shouldn't need curly braces here. ArrayRef has a conversion constructor
th
erichkeane updated this revision to Diff 113424.
erichkeane marked 4 inline comments as done.
https://reviews.llvm.org/D36707
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
==
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
erichkeane created this revision.
A small set of refactors that'll make it easier for me to implement 'target'
support.
First, extract the CPUSupports functionality into its own function. THis has
the advantage of not wasting time in this builtin to deal with arguments.
Second, pulls both CP
erichkeane updated this revision to Diff 111061.
erichkeane added a comment.
Thinking about it further, the emit functions should be private in this case.
https://reviews.llvm.org/D36707
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
===
Don't wait on me here.
On Thu, Aug 31, 2017, 10:53 PM Craig Topper via Phabricator <
revi...@reviews.llvm.org> wrote:
> craig.topper accepted this revision.
> craig.topper added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
> https://reviews.llvm.org/D36707
>
>
>
>
__
-commits@lists.llvm.org
Subject: Re: [PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code
Gen to better work with "target" implementation
Don't wait on me here.
On Thu, Aug 31, 2017, 10:53 PM Craig Topper via Phabricator
mailto:revi...@reviews.llvm.org>> wrote:
craig
12 matches
Mail list logo
