This revision was automatically updated to reflect the committed changes.
Closed by commit rL311319: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests
(authored by sam_parker).
Changed prior to commit:
https://reviews.llvm.org/D36731?vs=111664&id=111940#toc
Repository:
rL LLVM
https://reviews.
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks good to me too.
Two nits (no new review required): one is inlined, and the other one in the
summary: ARMv8.2-A => Armv8.2-A :-/
Comment at: test/Driver/
rengolin added a comment.
I'm happy with the patch, but I'll let @SjoerdMeijer approve.
https://reviews.llvm.org/D36731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samparker updated this revision to Diff 111664.
samparker added a comment.
Reverted the default cpu v8.2-a to generic, I will update
https://reviews.llvm.org/D36667 accordingly. Also fixed up the boolean issues.
https://reviews.llvm.org/D36731
Files:
lib/Driver/ToolChains/Arch/ARM.cpp
test
samparker added a comment.
Thanks guys, I will sort my logic out.
Renato, the new Decode function is really just there to allow me to double
check the target features. This is already possible with AArch64 and it just
felt right to also be able to test ARM in the same way. I've renamed the titl
