[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

This revision was automatically updated to reflect the committed changes. Closed by commit rL311191: [Sema] Don't emit -Wunguarded-availability for switch cases (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D36777?vs=111528&id=111727#toc Repository: rL LLVM https://

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

erik.pilkington updated this revision to Diff 111528. erik.pilkington added a comment. Ah, good point. This new patch does that. Thanks, Erik https://reviews.llvm.org/D36777 Files: lib/Sema/SemaDeclAttr.cpp test/SemaObjC/unguarded-availability.m Index: test/SemaObjC/unguarded-availability

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

arphaman added a comment. Thanks! There are two issues that I see: Comment at: lib/Sema/SemaDeclAttr.cpp:7519 +// to any useful diagnostics. +for (Stmt *Child : llvm::drop_begin(CS->children(), 1)) + if (!Base::TraverseStmt(Child)) GNU case stateme

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

erik.pilkington created this revision. Currently, this has pretty terrible ergonomics for the fairly common case of switching over an enum which has some entries that are partial. Thanks to Nico Weber for pointing this out! Thanks, Erik https://reviews.llvm.org/D36777 Files: lib/Sema/SemaD