This revision was automatically updated to reflect the committed changes.
Closed by commit rL311778: [Basic] Add a DiagnosticError llvm::ErrorInfo
subclass (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36969?vs=112327&id=112700#toc
Repository:
rL LLVM
https://re
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D36969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
arphaman updated this revision to Diff 112327.
arphaman added a comment.
Add helper functions as suggested by Vedant.
Repository:
rL LLVM
https://reviews.llvm.org/D36969
Files:
include/clang/Basic/DiagnosticError.h
lib/Basic/Diagnostic.cpp
unittests/Basic/DiagnosticTest.cpp
Index: uni
arphaman marked 2 inline comments as done.
arphaman added a comment.
In https://reviews.llvm.org/D36969#848906, @vsk wrote:
> Nice! I'd like to get your thoughts on two candidate ergonomic changes:
Makes sense, I've added two similar helper functions in the updated patch.
Repository:
rL LLV
vsk added a comment.
Nice! I'd like to get your thoughts on two candidate ergonomic changes:
Comment at: unittests/Basic/DiagnosticTest.cpp:81
+ llvm::Expected> Value =
+ llvm::make_error(PartialDiagnosticAt(
+ SourceLocation(), PartialDiagnostic(diag::err_cannot
arphaman updated this revision to Diff 112169.
arphaman retitled this revision from "[Basic] Add a DiagnosticOr type" to
"[Basic] Add a DiagnosticError llvm::ErrorInfo subclass".
arphaman edited the summary of this revision.
arphaman added a comment.
Use `ErrorInfo` subclass as suggested by Vedan
