[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

chh added a comment. Please review https://reviews.llvm.org/D35743. I uploaded there a new diff that should fix the spaces around & and && tokens. Thanks. https://reviews.llvm.org/D37132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

chh added a comment. Thanks for this change. Could you take a look of https://reviews.llvm.org/D35743 too? This outputs a space before and after "&" or "&&", like this "auto & [...", "auto && [..." Could we remove one of the space to a format like the following? "auto& [...", "auto&&

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Sorry for the delay. https://reviews.llvm.org/D37132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113084. curdeius added a comment. Fix: use do-while loop. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113079. curdeius added a comment. Extract method. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113077. curdeius added a comment. Fix line endings again. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113073. curdeius added a comment. Fix line endings. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

djasper added a comment. Are you changing the line endings here? Phabricator tells me that basically all the lines change. If so, please don't ;). Comment at: lib/Format/TokenAnnotator.cpp:345 + +FormatToken *PreviousNoneOfConstVolatileReference = Parent; +while