hamzasood updated this revision to Diff 114784.
hamzasood added a comment.
Changed a CMake macro to a function.
https://reviews.llvm.org/D37376
Files:
CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMa
compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
Comment at: lib/CMakeLists.txt:189
+macro(add_msvcrt_defs_if_needed target)
+ if(WIN32 AND NOT MINGW)
Please use `function` rather than
hamzasood created this revision.
Herald added a subscriber: mgorny.
This patch fixes a few problems with building libc++experimental on Windows.
Previously _LIBCPP_BUILDING_LIBRARY was defined for every source file,
including files destined for the experimental library. As a result of this,
non