This revision was automatically updated to reflect the committed changes.
Closed by commit rL314752: [ubsan] Skip alignment checks which are folded away
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37544?vs=116374&id=117461#toc
Repository:
rL LLVM
https://review
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
vsk updated this revision to Diff 116374.
vsk added a comment.
- Tighten up lit test.
https://reviews.llvm.org/D37544
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/ubsan-suppress-checks.cpp
Index: test/CodeGenCXX/ubsan-suppress-checks.cpp
==
vsk added a comment.
Sorry, I see the issue now. The pre-patch IR looked like "br i1 true, label
%continue, label %diagnose", so there was no alignment check, per-se.
https://reviews.llvm.org/D37544
___
cfe-commits mailing list
cfe-commits@lists.ll
arphaman added a comment.
This one passes for me too without the code change.
https://reviews.llvm.org/D37544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk updated this revision to Diff 115879.
vsk added a comment.
- Use a better test case. This one was lifted from an actual example in
X86CallingConv.h:86.
https://reviews.llvm.org/D37544
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/ubsan-suppress-checks.cpp
Index: test/CodeGenCXX/ubsan
arphaman added a comment.
It looks like this test passes prior to the code change in this patch. Can you
please change the test?
https://reviews.llvm.org/D37544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
vsk created this revision.
Don't emit alignment checks which the IR constant folder throws away.
I've tested this out on X86FastISel.cpp. While this doesn't decrease
end-to-end compile-time significantly, it results in 122 fewer type
checks (1% reduction) overall, without adding any real complexi
