gtbercea updated this revision to Diff 116621.
gtbercea added a comment.
Split line.
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
=
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One small nit. LGTM otherwise.
Comment at: test/Driver/openmp-offload-gpu.c:133
+/// Check that the flag is passed when -fopenmp-relocatable-target is used.
+// RUN: %clang -###
gtbercea updated this revision to Diff 115943.
gtbercea added a comment.
Don't take into account unknown CUDA archs not even for testing purposes.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driv
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:255-257
CudaArch gpu_arch = StringToCudaArch(GPUArchName);
- assert(gpu_arch != CudaArch::UNKNOWN &&
+ assert((gpu_arch != CudaArch::UNKNOWN ||
+ Args.hasArg(options::OPT_nocudalib)) &&
--
gtbercea updated this revision to Diff 115692.
gtbercea added a comment.
Add test.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
hfinkel added a comment.
Please add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea created this revision.
Enable the -nocudalib flag for the OpenMP device offloading toolchain as well.
Currently it can only be used for the CUDA toolchain.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cud
