gtbercea reopened this revision.
gtbercea added a comment.
This revision is now accepted and ready to land.
Open.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gtbercea updated this revision to Diff 115948.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
===
---
hfinkel added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:140
+
+/// Check that error is not thrown by toolchain when no cuda lib device is
found when using -c -S.
+/// Check that the flag is passed when -fopenmp-relocatable-target is used.
Do
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:133
+/// Check that the flag is passed when -fopenmp-relocatable-target is used.
+// RUN: %clang -### -c -S -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target -march=sm_99
gtbercea updated this revision to Diff 115697.
gtbercea added a comment.
Only check for -S.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
tra added a comment.
I'm not particularly familiar with OpenMP internals. Could you elaborate on why
libdevice would not be needed with -c for the OpenMP case?
Is that because it would only apply to the host compilation and that nothing
will be compiled for the openmp targets?
Does openmp allow
gtbercea updated this revision to Diff 115502.
gtbercea added a comment.
Fix diff.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
gtbercea updated this revision to Diff 115500.
gtbercea added a comment.
Add test.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
tra added a comment.
Now we just need a test case to make sure this works as intended.
https://reviews.llvm.org/D37914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 115481.
gtbercea added a comment.
Fix condition.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
gtbercea updated this revision to Diff 115447.
gtbercea added a comment.
Fix parantheses.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
gtbercea updated this revision to Diff 115444.
gtbercea added a comment.
Contract check.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:505-508
+if ((DeviceOffloadingKind == Action::OFK_OpenMP &&
+ DriverArgs.hasArg(options::OPT_S)) ||
+(DeviceOffloadingKind == Action::OFK_OpenMP &&
+
gtbercea created this revision.
If we only use the compiler front-end, do not throw an error about the cuda
device library not being found. This allows the front-end to be run on systems
where no Cuda installation is found.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
14 matches
Mail list logo