[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-23 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. (FWIW, the suggestion to use `FileManager:getCanonicalName` did not work because I have no DirectoryEntry. And `-no-canonical-prefixes` it used very early and stripped from normal options, it seems used for a different purpose. Given the opposition, I think that

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-21 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. I think the diagnosis on the original issue was incorrect. It seems to me that it was caused by the prefix being set as "/bin" instead of "/usr/bin", because clang _doesn't_ actually canonicalize its prefix, even when -no-canonical-prefixes isn't specified! All it

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-20 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. This is not about any operating system, but basic consistent behavior. either do the canonicalisation or not. Doing it sometimes is just bogus. You've effectively implemented -fcanonical-system-headers=sometimes. Repository: rL LLVM https://reviews.llvm.org/D37954

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-19 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. In https://reviews.llvm.org/D37954#901878, @rsmith wrote: > In https://reviews.llvm.org/D37954#884029, @Lekensteyn wrote: > > > Any objection for merging these patches? I rebased today (no changes > > needed) and it still passes clang-tests. > > > This is not the way

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-19 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. The behavior of sometimes transforming the path and sometimes not is IMO completely unacceptable. I don't care if GCC created that bug first. Repository: rL LLVM https://reviews.llvm.org/D37954 ___ cfe-commits mailing

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-19 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D37954#884029, @Lekensteyn wrote: > Any objection for merging these patches? I rebased today (no changes needed) > and it still passes clang-tests. This is not the way that we do code review in LLVM and Clang. If you don't get a response to

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-19 Thread Peter Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316193: Try to shorten system header paths when using -MD depfiles (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D37954?vs=115946=119626#toc Repository: rL LLVM

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-10-12 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. ping? I'll push it next week if there is no new feedback. https://reviews.llvm.org/D37954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-09-28 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. Any objection for merging these patches? I rebased today (no changes needed) and it still passes clang-tests. https://reviews.llvm.org/D37954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-09-20 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. Well, the background for the use of the option in NetBSD is related to inducted differences in reproducable builds. From that perspective, it is even worth to sometimes shorten the dependency and sometimes not. https://reviews.llvm.org/D37954

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

2017-09-19 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn updated this revision to Diff 115946. Lekensteyn retitled this revision from "Expand absolute system header paths when using -MD depfiles" to "Try to shorten system header paths when using -MD depfiles". Lekensteyn edited the summary of this revision. Lekensteyn added a comment.