This revision was automatically updated to reflect the committed changes.
Closed by commit rL313730: [clangd] Introduced Logger interface. (authored by
ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D37972
Files:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools-extra/tr
malaperle accepted this revision.
malaperle added a comment.
This revision is now accepted and ready to land.
Look good. Thank you!
https://reviews.llvm.org/D37972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ilya-biryukov updated this revision to Diff 115818.
ilya-biryukov added a comment.
- Replaced JSONOutput in Protocol.h/Protocol.cpp with Logger.
https://reviews.llvm.org/D37972
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:88
if (!Error.empty()) {
-// FIXME(ibiryukov): logging
-// Output.log("Error when trying to load compilation database from " +
-//Twine(Path) + ": " +
ilya-biryukov updated this revision to Diff 115648.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
Addressed review comments.
- Replaced include with forward declaration in headers.
- Removed logging on each call to loadFromDirectory.
https://reviews.llvm.org/D37
malaperle added a comment.
Looks very nice! Just a few questions.
Comment at: clangd/ClangdServer.h:24
#include "ClangdUnit.h"
+#include "Logger.h"
#include "Protocol.h"
forward declare?
Comment at: clangd/ClangdUnit.h:13
+#include "Logge
ilya-biryukov created this revision.
Herald added a subscriber: mgorny.
This fixes a bunch of logging-related FIXMEs.
https://reviews.llvm.org/D37972
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/Cl
