This revision was automatically updated to reflect the committed changes.
Closed by commit rC337017: Fix PR34668 - P0704R1 implementation is too
permissive (authored by Rakete, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38075?vs=155410&id=155412#toc
Repository:
rC
Rakete updated this revision to Diff 155410.
Rakete added a comment.
Change error message to reflect the new update error message since the last
revision.
Repository:
rC Clang
https://reviews.llvm.org/D38075
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx2a-pointer-to-const-ref
tcanens added a comment.
In https://reviews.llvm.org/D38075#1161325, @Rakete wrote:
> Do you need someone to commit it?
Yes, please.
https://reviews.llvm.org/D38075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Rakete accepted this revision.
Rakete added a comment.
This revision is now accepted and ready to land.
LGTM with a small change in the error message that needs fixing.
Do you need someone to commit it?
https://reviews.llvm.org/D38075
___
c
tcanens updated this revision to Diff 116490.
tcanens added a comment.
Also tweaked preceding comment.
https://reviews.llvm.org/D38075
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp
Index: test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp
=
Rakete added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+if (Proto->isConst() && !Proto->isVolatile
tcanens added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+if (Proto->isConst() && !Proto->isVolatile())
Rakete added a comment.
Thanks! That was an oversight on my part, sorry.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+
tcanens created this revision.
tcanens added a project: clang.
https://bugs.llvm.org/show_bug.cgi?id=34668
Pretty straightforward.
Repository:
rL LLVM
https://reviews.llvm.org/D38075
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp
Index: test/SemaCXX
