marco-c added a comment.
The change was already positively reviewed with the request for a test, which
has been written since then.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT321703: Hide some symbols to avoid a crash on shutdown
when using code coverage (authored by marco, committed by ).
Hera
sylvestre.ledru added a comment.
I added two more reviewers as we would like to get that in trunk before 6.0
branches.
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
sylvestre.ledru added a comment.
@davidxl David, is that ok with you? Can you sign off this change? Thanks
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
sylvestre.ledru added a comment.
please thank Marco :)
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
belleyb added a comment.
@sylvestre.ledru Thanks for the test!
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru updated this revision to Diff 122077.
sylvestre.ledru edited the summary of this revision.
https://reviews.llvm.org/D38124
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
test/profile/instrprof-dlopen-dlclose-gcov.test
Index: test/prof
belleyb added a comment.
Autodesk would also like to see this fix merged into LLVM 5.0.1 and we also
agree about the importance of having a regression tests.
@sylvestre.ledru : Is someone on the Firefox team working on writing a unit
test for this ? Shall we jump-in and try to help ?
https://
davidxl added a comment.
Can you add a test case with shared libraries?
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru created this revision.
sylvestre.ledru added a project: clang.
gcov / gcda-based profiling crashes when shared libraries are unloaded
Patch by Benoit Belley and tested by Marco Castelluccio for Firefox
See https://bugs.llvm.org/show_bug.cgi?id=27224 &
https://bugzilla.mozilla.or
10 matches
Mail list logo
