kosarev abandoned this revision.
kosarev added a comment.
Indeed, if LValueBaseInfo is what we know about the very first value in a
sequence, then TBAA info certainly should not be part of it. This also means
whatever is specified as a direct base lvalue to the lvalue we are constructing
should
rjmccall added a comment.
Hmm. I'm not sure I like the design of merging TBAAAccessInfo into
LValueBaseInfo. LValueBaseInfo is currently the set of information that's
generally preserved across l-value manipulations. It was extracted from LValue
specifically to create an encapsulated entity
kosarev updated this revision to Diff 119373.
kosarev edited the summary of this revision.
kosarev added a comment.
Rebased on top of https://reviews.llvm.org/D39008 and ready for review.
https://reviews.llvm.org/D38126
Files:
CodeGen/CGAtomic.cpp
CodeGen/CGClass.cpp
CodeGen/CGExpr.cpp
kosarev added a comment.
Please take a look at https://reviews.llvm.org/D38695, if you want this by
smaller pieces. Thanks.
https://reviews.llvm.org/D38126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
kosarev updated this revision to Diff 118200.
kosarev added a comment.
Removed the extra ###include##.
https://reviews.llvm.org/D38126
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGObjCRuntime.cpp
lib/CodeGen/CGO
kosarev added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:55
#include "llvm/IR/Module.h"
+#include "llvm/IR/Verifier.h" // TODO
#include "llvm/ProfileData/InstrProfReader.h"
Oops. Will be removed.
https://reviews.llvm.org/D38126
___
kosarev updated this revision to Diff 118045.
kosarev edited the summary of this revision.
kosarev added a comment.
Re-based on top of the previous refinements: https://reviews.llvm.org/D38404,
https://reviews.llvm.org/D38408, https://reviews.llvm.org/D38456,
https://reviews.llvm.org/D38460, htt
kosarev added a comment.
Sure, will do. Just added it to https://reviews.llvm.org/D38074. Thanks.
https://reviews.llvm.org/D38126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added subscribers: cfe-commits, efriedma.
efriedma added a comment.
Please make sure to add the mailing list as a subscriber when you post a patch.
(I haven't looked at the patch yet.)
https://reviews.llvm.org/D38126
___
cfe-commits maili
