This revision was automatically updated to reflect the committed changes.
Closed by commit rL314336: Add support for remembering origins to
ExternalASTMerger (authored by spyffe).
Changed prior to commit:
https://reviews.llvm.org/D38208?vs=116680=116868#toc
Repository:
rL LLVM
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D38208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
spyffe updated this revision to Diff 116680.
spyffe added a comment.
Updates and small refactors requested by Bruno.
Repository:
rL LLVM
https://reviews.llvm.org/D38208
Files:
include/clang/AST/ExternalASTMerger.h
lib/AST/ExternalASTMerger.cpp
lib/Sema/SemaType.cpp
Updated the diff. Unfortunately reviews.llvm.org is down, so I'll try
updating that page in the morning.
Sean
On 9/25/17 5:04 AM, Bruno Cardoso Lopes via Phabricator wrote:
bruno added inline comments.
Comment at: lib/AST/ExternalASTMerger.cpp:79
+ return
bruno added inline comments.
Comment at: lib/AST/ExternalASTMerger.cpp:79
+ return cast(SearchResultDecl)->getPrimaryContext();
+else
+ return nullptr; // This type of lookup is unsupported
No need for `else` here.
Comment at:
spyffe created this revision.
spyffe added a project: clang.
At @bruno 's request, recreating this with cfe-commits as a subscriber. The
original is https://reviews.llvm.org/D36589
`ExternalASTMerger` has hitherto relied on being able to look up any Decl
through its named `DeclContext` chain.
