Re: [PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Nicolas Lesser via cfe-commits
Yeah, I hang out there :) Will do for sure ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r314463. Btw, if you're not in the IRC channel (#llvm on OFTC), you should hang out in there to make sure no build bots break due to the commit. https://reviews.llvm.org/D38342 __

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Yes please :) Thanks @aaron.ballman https://reviews.llvm.org/D38342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? https://reviews.llvm.org/D38342 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 117054. Rakete added a comment. - Fixed test case for bools Ah got it! Thanks!! https://reviews.llvm.org/D38342 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx-bool.cpp Index: test/Parser/cxx-bool.cpp ===

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D38342#883872, @Rakete wrote: > - Moved test to test/CXX/ > > Do I actually need to -verify the test if no diagnostics are expected? > > Thanks @aaron.ballman Yes, you need to make sure that verify is on the RUN line. The existi

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 117051. Rakete added a comment. - Moved test to test/CXX/ Do I actually need to -verify the test if no diagnostics are expected? Thanks @aaron.ballman https://reviews.llvm.org/D38342 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx-bool.cpp Ind

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/CXX/expr/expr.post/expr.sub/p1.cpp:3-6 +void pr34273() { + char Normal = "clang"[true]; // expected-no-diagnostics + char Special = true["clang"]; // expected-no-diagnostics +} I think this test should be ad

[PATCH] D38342: [C++] Parse (sub) postfix expression after boolean literal

2017-09-27 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete created this revision. Rakete added a project: clang. Parsers a postfix expression after a boolean literal: This fixes PR34273 . https://reviews.llvm.org/D38342 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.post/expr.sub/p1.cp