This revision was automatically updated to reflect the committed changes.
Closed by commit rL314895: Fix assertion failure in thread safety analysis
(PR34800). (authored by alexfh).
Repository:
rL LLVM
https://reviews.llvm.org/D38458
Files:
alexfh updated this revision to Diff 117650.
alexfh added a comment.
Get rid of a local string variable.
https://reviews.llvm.org/D38458
Files:
include/clang/Analysis/Analyses/ThreadSafetyTIL.h
test/SemaCXX/warn-thread-safety-analysis.cpp
Index:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D38458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added inline comments.
Comment at: include/clang/Analysis/Analyses/ThreadSafetyTIL.h:931-936
+if (!SlotName) {
+ std::string Buffer;
+ llvm::raw_string_ostream OS(Buffer);
+ Cvdecl->printName(OS);
+ SlotName = OS.str();
+}
BTW,
alexfh created this revision.
Fix an assertion failure and clean up unused code relevant to the fixed logic.
https://reviews.llvm.org/D38458
Files:
include/clang/Analysis/Analyses/ThreadSafetyTIL.h
test/SemaCXX/warn-thread-safety-analysis.cpp
Index:
