This revision was automatically updated to reflect the committed changes.
Closed by commit rL315488: [Analyzer] Assume that string-like const globals are
non-nil. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38764?vs=118657=118660#toc
Repository:
rL
george.karpenkov updated this revision to Diff 118657.
george.karpenkov marked 2 inline comments as done.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
george.karpenkov marked 9 inline comments as done.
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp:22
+// Checker uses are defined in the test file:
+// - test/Analysis/nonnull-string-constants.mm
+//
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me. Please fix the additional nits mentioned inline and commit!
Also, make sure to do a pass to update the capitalization of variables
throughout the file to match the
george.karpenkov updated this revision to Diff 118522.
george.karpenkov added a comment.
Typo fix.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
george.karpenkov added a comment.
Marking requests as "done".
https://reviews.llvm.org/D38764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov updated this revision to Diff 118521.
george.karpenkov marked 12 inline comments as done.
george.karpenkov added a comment.
Adhering to comments.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
dcoughlin added a comment.
Looks like a great start!
There are a bunch of minor nits inline.
The one big thing is that I think your handling of 'const char *' in
`typeIsConstString()` isn't quite right. 'const char *' means that the
pointed-to characters can't be modified but does allow
george.karpenkov updated this revision to Diff 118493.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/NonnilStringConstantsChecker.cpp
test/Analysis/nonnil-string-constants.mm
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun, mgorny.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/NonnilStringConstantsChecker.cpp
10 matches
Mail list logo