[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

2017-10-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316764: [CrossTU] Fix handling of Cross Translation Unit directory path (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D38842?vs=118773&id=120576#toc Repository: rL LLVM http

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

2017-10-27 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added a comment. LGTM as well, but same note applies. https://reviews.llvm.org/D38842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

2017-10-26 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl accepted this revision. r.stahl added a comment. This revision is now accepted and ready to land. I'm gonna go ahead and approve this now, because I reported the issue. Note that I'm not a regular contributor, yet! Comment at: lib/CrossTU/CrossTranslationUnit.cpp:99

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

2017-10-12 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. The function map generator tool always creates absolute path. The correct logic to determine whether a path should be handled as absolute depends on the value of the CrossTU directory. Added a unit test to avoid regressions. https://reviews.llvm.org/D38842 Fil