This revision was automatically updated to reflect the committed changes.
Closed by commit rL316314: [rename] Don't overwrite the template argument when
renaming a template… (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39120
Files:
cierpuchaw added inline comments.
Comment at: unittests/Rename/RenameFunctionTest.cpp:232
+ std::string Expected = R"(
+ namespace na {
+ template T Y();
Shouldn't this be `namespace nb {`?
https://reviews.llvm.org/D39120
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227
+SourceLocation EndLoc = Expr->hasExplicitTemplateArgs()
+? Expr->getLAngleLoc().getLocWithOffset(-1)
+:
hokein updated this revision to Diff 119654.
hokein marked an inline comment as done.
hokein added a comment.
Test for `foo ()`.
https://reviews.llvm.org/D39120
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/RenameFunctionTest.cpp
Index:
hokein added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227
+SourceLocation EndLoc = Expr->hasExplicitTemplateArgs()
+? Expr->getLAngleLoc().getLocWithOffset(-1)
+:
ioeric added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227
+SourceLocation EndLoc = Expr->hasExplicitTemplateArgs()
+? Expr->getLAngleLoc().getLocWithOffset(-1)
+:
hokein created this revision.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D39120
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/RenameFunctionTest.cpp
Index: unittests/Rename/RenameFunctionTest.cpp
