frutiger added a comment.
@jklaehn do you know why the referenced cursor would point to line 2?
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
It looks like the `my_var:2:1` refers to the result from
`clang_getCursorReferenced`:
https://github.com/llvm-mirror/clang/blob/d454549fce04dfedda6cc2825b66efca94effe3f/tools/c-index-test/c-index-test.c#L709-L711.
I'm not sure what a referenced cursor is in this conte
jklaehn added inline comments.
Comment at: test/Index/c-index-getCursor-test.m:167
// CHECK: [57:1 - 57:10] FunctionDecl=f:57:6 (Definition)
-// CHECK: [58:4 - 58:8] VarDecl=my_var:58:8 (Definition)
+// CHECK: [58:4 - 58:8] VarDecl=my_var:2:1 (Definition)
// CHECK: [58:8 - 58:1
frutiger added inline comments.
Comment at: test/Index/c-index-getCursor-test.m:167
// CHECK: [57:1 - 57:10] FunctionDecl=f:57:6 (Definition)
-// CHECK: [58:4 - 58:8] VarDecl=my_var:58:8 (Definition)
+// CHECK: [58:4 - 58:8] VarDecl=my_var:2:1 (Definition)
// CHECK: [58:8 - 58:
jklaehn added inline comments.
Comment at: test/Index/annotate-tokens.c:226
// CHECK-RANGE2: Punctuation: "." [55:5 - 55:6] UnexposedExpr=
-// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:52:1
+// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:41:9
// CHECK-
akyrtzi added a subscriber: arphaman.
akyrtzi added a comment.
CC'ed @arphaman.
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a subscriber: akyrtzi.
compnerd added a comment.
I think that this is reasonable given that it is addressing a long standing
issue. CC'ing @akyrtzi for his opinion as well.
https://reviews.llvm.org/D39217
___
cfe-commits mailing lis
frutiger added a comment.
I would very much appreciate some guidance on whether or not this kind of a
change in behaviour for `clang_getSpellingLocation` is an acceptable thing to
do.
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cf
frutiger updated this revision to Diff 119971.
frutiger added a comment.
Add context to the patch.
https://reviews.llvm.org/D39217
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
test/Index/annotate-tokens.c
test/Index/blocks.c
test/Index/c-index-a
frutiger created this revision.
- Add a 'Location' class that represents the four properties of a physical
location
- Enhance 'SourceLocation' to provide 'expansion' and 'spelling' locations,
maintaining backwards compatibility with existing code by forwarding the four
properties to 'expansion'
10 matches
Mail list logo