This revision was automatically updated to reflect the committed changes.
Closed by commit rL317493: [Parser] Fix TryParseLambdaIntroducer() error
handling (authored by jkorous).
Changed prior to commit:
https://reviews.llvm.org/D39419?vs=121448&id=121748#toc
Repository:
rL LLVM
https://rev
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
jkorous-apple updated this revision to Diff 121448.
jkorous-apple added a comment.
newline at the end of test file
https://reviews.llvm.org/D39419
Files:
lib/Parse/ParseExprCXX.cpp
test/Parser/objcxx11-invalid-lambda.cpp
Index: test/Parser/objcxx11-invalid-lambda.cpp
=
jkorous-apple added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1020
- PA.Commit();
- return false;
+ PA2.Revert();
+ return true;
arphaman wrote:
> Just to clarify: It seems like this revert (in addition to two TPAs) is the
> main addition. Di
arphaman added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1020
- PA.Commit();
- return false;
+ PA2.Revert();
+ return true;
Just to clarify: It seems like this revert (in addition to two TPAs) is the
main addition. Did we hit the assertion pr
jkorous-apple created this revision.
https://reviews.llvm.org/D39419
Files:
lib/Parse/ParseExprCXX.cpp
test/Parser/objcxx11-invalid-lambda.cpp
Index: test/Parser/objcxx11-invalid-lambda.cpp
===
--- /dev/null
+++ test/Parser/obj
