This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL317780: [clangd] Add rename support. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D39676?vs=122074&id=12#toc
Repository:
rL LLVM
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:67
+
+ // Using the handle(SymbolOccurrences) from parent class.
+ using tooling::RefactoringResultConsumer::handle;
sammccall wrote:
> why is this needed
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdServer.cpp:67
+
+ // Using the handle(SymbolOccurrences) from parent class.
+ using tooling::RefactoringResultConsumer::handle;
-
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:347
+
+void handle(tooling::SymbolOccurrences) override {}
+
sammccall wrote:
> hokein wrote:
> > sammccall wrote:
> > > I don't think you need to override this, assuming you don't expect any o
hokein updated this revision to Diff 122074.
hokein marked 2 inline comments as done.
hokein added a comment.
Simplify the code.
https://reviews.llvm.org/D39676
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:338
+std::vector
+ClangdServer::Rename(PathRef File, Position Pos, llvm::StringRef NewName) {
hokein wrote:
> sammccall wrote:
> > I think you can split out a private method:
> >
> > Expe
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:338
+std::vector
+ClangdServer::Rename(PathRef File, Position Pos, llvm::StringRef NewName) {
sammccall wrote:
> I think you can split out a private method:
>
> Expected>
> ClangdServer::ap
hokein updated this revision to Diff 122060.
hokein marked 10 inline comments as done.
hokein added a comment.
- address review comments.
- add error handling.
https://reviews.llvm.org/D39676
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdS
ilya-biryukov added a comment.
Just a few minor code style comments.
Comment at: clangd/ClangdServer.cpp:367
+Context.setASTContext(AST->getASTContext());
+auto rename = clang::tooling::RenameOccurrences::initiate(
+Context, SourceRange(SourceLocationBeg), NewNa
arphaman added a comment.
Side-comment: will want to let the user know about the fact that global symbols
aren't really renamed yet until global rename works?
https://reviews.llvm.org/D39676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
sammccall added a comment.
Impl LG apart from error handling :-)
Comment at: clangd/ClangdServer.cpp:338
+std::vector
+ClangdServer::Rename(PathRef File, Position Pos, llvm::StringRef NewName) {
I think you can split out a private method:
Expected>
Clan
hokein created this revision.
Herald added a subscriber: mgorny.
Make clangd handle "textDocument/rename" request. The rename
functionality comes from the "local-rename" sub-tool of clang-refactor.
Currently clangd only supports local rename (only symbol occurrences in
the main file will be renam
12 matches
Mail list logo
