[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317700: [analyzer] Fix a crash on logical operators with vectors. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D39682?vs=121856&id=122108#toc Repository: rL LLVM https:

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-07 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. Interesting bug! The workaround looks good to me. https://reviews.llvm.org/D39682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 121856. NoQ added a comment. A better name for the test function. https://reviews.llvm.org/D39682 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp test/Analysis/vector.c Index: test/Analysis/vector.c =

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 121725. NoQ added a comment. Yep, right! https://reviews.llvm.org/D39682 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp test/Analysis/vector.c Index: test/Analysis/vector.c === --- /dev/null

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:633 +// modeled as short-circuit in Clang CFG but this is incorrect. +StmtNodeBuilder Bldr(Pred, Dst,

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

2017-11-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. We crash whenever we try to compute `x && y` or `x || y` where `x` and `y` are of vector type. For now we do not seem to properly model operations with vectors. In particular, operations `&&` and `||` on two values of type `int __attribute__((ext_vector_type(2)))` ar