[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

gpakosz added a comment. >> Should I open a bug? > > I think opening a bug is appropriate, good catch! Thanks for the reply Aaron. Here's the report: https://github.com/llvm/llvm-project/issues/57151 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3976/new/

[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

aaron.ballman added a comment. In D3976#3721421 , @gpakosz wrote: > Hello, > > As of today, `-Wcomma` is not really documented: > https://clang.llvm.org/docs/DiagnosticsReference.html#wcomma > >> The current whitelisted expressions are increments,

[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

gpakosz added a comment. Herald added a project: All. Hello, As of today, `-Wcomma` is not really documented: https://clang.llvm.org/docs/DiagnosticsReference.html#wcomma > The current whitelisted expressions are increments, decrements, assignments, > compound assignments, overloaded versions

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

ovyalov added a subscriber: ovyalov. ovyalov added a comment. It seems this CL broke LLDB CMake build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11554 Could you take a look? Repository: rL LLVM http://reviews.llvm.org/D3976

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

So, this week got consumed by -Wconstant-conversion. We'll see how next week goes. On Fri, Jan 29, 2016 at 7:16 PM, Richard Trieu wrote: > rtrieu added a comment. > > Not sure what happened. Will check it out on Monday. > > > http://reviews.llvm.org/D3976 > > > >

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

rtrieu added a comment. Not sure what happened. Will check it out on Monday. http://reviews.llvm.org/D3976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

thakis added a comment. Did this ever land? Looks like it's lgtm'd and ready to go, and it looks like a useful warning. http://reviews.llvm.org/D3976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org