This revision was automatically updated to reflect the committed changes.
Closed by commit rL318141: Refactor ContinuationIndenter's breakProtrudingToken
logic. (authored by klimek).
Repository:
rL LLVM
https://reviews.llvm.org/D39900
Files:
cfe/trunk/lib/Format/BreakableToken.cpp
cfe/tru
klimek added a comment.
In https://reviews.llvm.org/D39900#921885, @krasimir wrote:
> Maybe we should further refactor `getRawStringStyle` into
> `llvm::Optional> getRawStringStyleAndDelimiter`
> and that would nicely take care of the duplicated effort?
I thought about that, too, but I'm stil
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Maybe we should further refactor `getRawStringStyle` into
`llvm::Optional> getRawStringStyleAndDelimiter` and
that would nicely take care of the duplicated effort?
https://reviews.llvm.o
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1028
+ unsigned Penalty =
+ handleEndOfLine(Current, State, DryRun, AllowBreak);
krasimir wrote:
> Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of
>
klimek updated this revision to Diff 122433.
klimek marked an inline comment as done.
klimek added a comment.
- Add test.
Updating D39900: Refactor ContinuationIndenter's breakProtrudingToken logic
into slightly more
===
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1028
+ unsigned Penalty =
+ handleEndOfLine(Current, State, DryRun, AllowBreak);
Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of the
line?
==
klimek created this revision.
This patch allowed me to experiment with various alternatives to
https://reviews.llvm.org/D33589.
https://reviews.llvm.org/D39900
Files:
lib/Format/BreakableToken.cpp
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
unittests/Format/Fo
