aaronpuchert added inline comments.
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24
+ void lvalue() &; // expected-note 2 {{'lvalue' declared here}}
+ void const_lvalue() const&;
+ void rvalue() &&; // expected-note {{'rvalue' declared here}}
jtbandes added a comment.
After merging the buildbots informed me some other tests were broken that I
failed to notice. I reverted this commit and submitted
https://reviews.llvm.org/D41646 which reintroduces the changes and fixes the
other broken tests.
Repository:
rC Clang
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321592: [Sema] Improve diagnostics for const- and
ref-qualified member functions (authored by jtbandes, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D39937?vs=123481&id=128366#toc
aaron.ballman added a comment.
You're set to commit (if there are concerns, @rsmith can raise them
post-commit). Do you need me to commit on your behalf?
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D39937#929514, @jtbandes wrote:
> Thanks, will do. Is there an automated system that can run all the tests
> //before// I merge rather than waiting for a potential build failure after
> the fact?
You can run the tests locally using ll
jtbandes added a comment.
Thanks, will do. Is there an automated system that can run all the tests
//before// I merge rather than waiting for a potential build failure after the
fact?
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cf
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, but you should wait for a few days before committing in case @rsmith
has comments.
https://reviews.llvm.org/D39937
___
jtbandes updated this revision to Diff 123481.
jtbandes added a comment.
- spell out full diagnostic the first time
https://reviews.llvm.org/D39937
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/CXX/over/over.match/over.match.funcs/p4-0x.cpp
test/SemaCX
aaron.ballman added inline comments.
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:85
+void test_diagnostics(const volatile X0 &__restrict__ cvr) {
+ cvr.g(); // expected-error {{not marked const or volatile}}
+ cvr.c(); // expected-error {{not marked volatile
jtbandes updated this revision to Diff 123476.
jtbandes added a comment.
- feedback from review & more tests
https://reviews.llvm.org/D39937
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/CXX/over/over.match/over.match.funcs/p4-0x.cpp
test/SemaCXX/copy-
lebedev.ri added inline comments.
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24
+ void lvalue() &; // expected-note 2 {{'lvalue' declared here}}
+ void const_lvalue() const&;
+ void rvalue() &&; // expected-note {{'rvalue' declared here}}
--
aaron.ballman added inline comments.
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24
+ void lvalue() &; // expected-note 2 {{'lvalue' declared here}}
+ void const_lvalue() const&;
+ void rvalue() &&; // expected-note {{'rvalue' declared here}}
---
jtbandes added inline comments.
Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24
+ void lvalue() &; // expected-note 2 {{'lvalue' declared here}}
+ void const_lvalue() const&;
+ void rvalue() &&; // expected-note {{'rvalue' declared here}}
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize object parameter of type %0 with an expression "
+ "of type %1">;
jtbandes wrote:
> aaron.bal
jtbandes added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize object parameter of type %0 with an expression "
+ "of type %1">;
aaron.ballman wrote:
> I don't t
aaron.ballman added reviewers: rsmith, aaron.ballman.
aaron.ballman added a comment.
I think the new wording is a bit more clear, in general.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597
+def err_member_function_call_other : Error<
+ "cannot initialize obje
jtbandes created this revision.
Adjust wording for const-qualification mismatch to be a little more clear.
Also add another diagnostic for a ref qualifier mismatch, which previously
produced a useless error (this error path is simply very old; see
https://reviews.llvm.org/rL119336):
Before:
18 matches
Mail list logo
