This revision was automatically updated to reflect the committed changes.
Closed by commit rL318440: [MS] Apply adjustments after storing 'this'
(authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D40109?vs=123104=123218#toc
Repository:
rL LLVM
rnk added a comment.
In https://reviews.llvm.org/D40109#926975, @rnk wrote:
> This seems to cause a crash on startup in some gtest binaries when I
> self-host, so I guess I should debug that tomorrow before committing. The
> rest of clang's tests pass. I guess we don't use virtual inheritance.
rnk added a comment.
This seems to cause a crash on startup in some gtest binaries when I self-host,
so I guess I should debug that tomorrow before committing. The rest of clang's
tests pass. I guess we don't use virtual inheritance. =S
https://reviews.llvm.org/D40109
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D40109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk created this revision.
Herald added a subscriber: aprantl.
The MS ABI convention is that the 'this' pointer on entry is the address
of the vfptr that was used to make the virtual method call. In other
words, the pointer on entry always points to the base subobject that
introduced the virtual
