EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting for post-commit review. I don't want to be carrying this patch
locally.
https://reviews.llvm.org/D40217
___
cfe-commits mailing list
EricWF updated this revision to Diff 123485.
EricWF added a comment.
- Use style suggested by @mgorny.
https://reviews.llvm.org/D40217
Files:
utils/lit/lit/llvm/config.py
Index: utils/lit/lit/llvm/config.py
===
---
mgorny added a comment.
Or even more abstract (if we assume we don't have to check for presence of
`llvm_tools_dir`):
path_vars = ['clang_tools_dir', 'llvm_tools_dir']
paths = [getattr(self.config, k) for k in path_vars if hasattr(self.config,
k)]
(untested)
mgorny added a comment.
To be honest, as I said before, I'm entirely confused by the logic there, with
all the prepending, appending and shuffling around. But if you believe it gives
the correct result, I'm all for it.
However, if that wouldn't be too much of a hassle, would you mind also
+mgorny
On Sat, Nov 18, 2017 at 2:24 PM Eric Fiselier via Phabricator <
revi...@reviews.llvm.org> wrote:
> EricWF created this revision.
> Herald added a reviewer: modocache.
>
> Currently, LIT configures the LLVM binary path before the Clang binary
> path. However this breaks testing
EricWF created this revision.
Herald added a reviewer: modocache.
Currently, LIT configures the LLVM binary path before the Clang binary path.
However this breaks testing out-of-tree Clang builds (where the LLVM binary
path includes a copy of Clang).
This patch reverses the order of the paths
