[PATCH] D40450: [clangd] Refactoring of GlobalCompilationDatabase

2017-11-27 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. @Nebiroth , Will this be compatible with your patch to change CompilationDatabase at runtime? https://reviews.llvm.org/D39571 https://reviews.llvm.org/D40450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D40450: [clangd] Refactoring of GlobalCompilationDatabase

2017-11-27 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:254 + std::move(Primary), llvm::make_unique( + ".", ArrayRef{})); +} Clangd still changes working directory when running the parsing, so `"."` might en

[PATCH] D40450: [clangd] Refactoring of GlobalCompilationDatabase

2017-11-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. The interface used is now tooling::CompilationDatabase. The various behaviors of the existing CDB implementation is decomposed into several classes responsible for one aspect each. - The fallback commands are now a FixedCompilationDatabase. For now, this is done