malaperle added inline comments.
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context , const FuzzyFindRequest ,
+std::function Callback) const = 0;
sammccall wrote:
> ioeric wrote:
> > malaperle wrote:
> >
sammccall added inline comments.
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context , const FuzzyFindRequest ,
+std::function Callback) const = 0;
ioeric wrote:
> malaperle wrote:
> > ioeric wrote:
> > >
ioeric added inline comments.
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context , const FuzzyFindRequest ,
+std::function Callback) const = 0;
malaperle wrote:
> ioeric wrote:
> > malaperle wrote:
> > > I
malaperle added inline comments.
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context , const FuzzyFindRequest ,
+std::function Callback) const = 0;
ioeric wrote:
> malaperle wrote:
> > I think a more
ioeric added a comment.
In https://reviews.llvm.org/D40548#955289, @malaperle wrote:
> In https://reviews.llvm.org/D40548#947081, @ioeric wrote:
>
> > Hi Marc, the patch is not ready for review yet. I am still cleaning up the
> > prototype and will let you know when it's ready for review.
>
>
>
malaperle added a comment.
In https://reviews.llvm.org/D40548#947081, @ioeric wrote:
> Hi Marc, the patch is not ready for review yet. I am still cleaning up the
> prototype and will let you know when it's ready for review.
I guess it was ready to review since it was submitted? ;)
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE320688: [clangd] Symbol index interfaces and an in-memory
index implementation. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40548?vs=126919=126924#toc