[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

2017-11-29 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris created this revision. The -fxray-always-emit-customevents flag instructs clang to always emit the LLVM IR for calls to the `__xray_customevent(...)` built-in function. The default behaviour currently respects whether the function has an `[[clang::xray_never_instrument]]` attribute, and th

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

2017-11-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Not totally clear to me why this feature is desirable, but assume you've got use cases/reasons :) Comment at: clang/lib/Driver/XRayArgs.cpp:32-33 constexpr char XRayNev

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

2017-11-29 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 124842. dberris marked an inline comment as done. dberris edited the summary of this revision. dberris added a comment. Updated description, address review comment(s). https://reviews.llvm.org/D40601 Files: clang/include/clang/Basic/LangOptions.def clan

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

2017-11-29 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added inline comments. Comment at: clang/lib/Driver/XRayArgs.cpp:32-33 constexpr char XRayNeverInstrumentOption[] = "-fxray-never-instrument="; +constexpr char XRayAlwaysEmitCustomEventsOption[] = +"-fxray-always-emit-customevents"; } // namespace d

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

2017-11-29 Thread Dean Michael Berris via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319388: [XRay][clang] Introduce -fxray-always-emit-customevents (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D40601?vs=124842&id=124846#toc Repository: rL LLVM https://re