faisalv added a comment.
Sounds good - if I don't get this done over the next seven days - would you
mind just pinging me!
Thanks!
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
miyuki added a comment.
I would appreciate, if you make those changes (because I'm very new to Clang
and I'm not sure that I understand how to move these checks to Sema correctly).
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-co
faisalv requested changes to this revision.
faisalv added a comment.
This revision now requires changes to proceed.
Hmm - I think i might make some tweaks to this patch (to be largely symmetric
with the similar handling of invalid decl-specifiers on function parameters in
Sema::Actions.ActOnPara
miyuki added a comment.
I don't have commit access. Please commit the patch on my behalf.
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki updated this revision to Diff 127324.
miyuki added a comment.
Merged two diagnostics into one
https://reviews.llvm.org/D40705
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseTemplate.cpp
test/CXX/temp/temp.param/p2-cpp11.cpp
test/CXX/temp/temp.param/p2.cpp
Ind
faisalv accepted this revision.
faisalv added a comment.
This revision is now accepted and ready to land.
Otherwise, I think this looks good enough to commit.
Do you have commit access? If not, let me know when you're ready for me to
commit it on your behalf ...
Thank you for fixing this!
==
miyuki updated this revision to Diff 126325.
miyuki added a comment.
Added a test for thead_local.
https://reviews.llvm.org/D40705
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseTemplate.cpp
test/CXX/temp/temp.param/p2-cpp11.cpp
test/CXX/temp/temp.param/p2.cpp
Index
rogfer01 added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:702
+ReportStorageClass(DS.getStorageClassSpecLoc());
+ if (DS.getThreadStorageClassSpec() != DeclSpec::TSCS_unspecified)
+ReportStorageClass(DS.getThreadStorageClassSpecLoc());
You
miyuki added a comment.
Ping
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki updated this revision to Diff 125119.
miyuki added a comment.
Use explicit lambda capture list.
https://reviews.llvm.org/D40705
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseTemplate.cpp
test/CXX/temp/temp.param/p2.cpp
Index: test/CXX/temp/temp.param/p2.cpp
==
faisalv added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:692
+ // declaration.
+ auto ReportStorageClass = [&](SourceLocation Loc) {
+if (ParamDecl.getIdentifier())
I tend to prefer explicit captures (unless you have a good reason?) - favori
miyuki created this revision.
[Parser] Diagnose storage classes in template parameter declarations
According to the C++ Standard [temp.param]p2:
A storage class shall not be specified in a template-parameter
declaration.
This patch implements a diagnostic for this restriction.
https://rev
12 matches
Mail list logo
