This revision was automatically updated to reflect the committed changes.
Closed by commit rL320604: [libcxx] Fix basic_stringbuf constructor (authored
by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40707?vs=126739&id=126779#toc
Repository:
rL LLVM
https://re
miyuki added a comment.
Yes, I don't have write access.
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need someone to commit it?
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
miyuki updated this revision to Diff 126739.
miyuki added a comment.
Use diff with context.
https://reviews.llvm.org/D40707
Files:
include/sstream
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp
Index:
test/std/input.output/string.streams/stringbuf/stringbu
miyuki updated this revision to Diff 126738.
miyuki added a comment.
Modified the test to use NULL instead of literal zero.
https://reviews.llvm.org/D40707
Files:
include/sstream
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp
Index:
test/std/input.output/s
mclow.lists added a comment.
This looks good to me; with a couple of nits.
Comment at:
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp:26
+{
+assert(this->eback() == 0);
+assert(this->gptr() == 0);
Not zero, p
miyuki added a comment.
Ping
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki created this revision.
[libcxx] Fix basic_stringbuf constructor
The C++ Standard [stringbuf.cons]p1 defines the effects of the basic_stringbuf
constructor that takes ios_base::openmode as follows:
Effects: Constructs an object of class basic_stringbuf, initializing the
base class with
