This revision was automatically updated to reflect the committed changes.
seaneveson marked an inline comment as done.
Closed by commit rL321992: [Driver] Add flag enabling the function stack size
section that was added in… (authored by seaneveson, committed by ).
Changed prior to commit:
https
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM
https://reviews.llvm.org/D40712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
seaneveson updated this revision to Diff 128745.
seaneveson added a comment.
Thanks Bruno,
Changed the default for cc1 to be false regardless of the target. The default
in the driver is still true for PS4 (only).
https://reviews.llvm.org/D40712
Files:
include/clang/Driver/Options.td
inclu
bruno added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:3783
+CmdArgs.push_back("-fno-stack-size-section");
+
CmdArgs.push_back("-ferror-limit");
What happens when you invoke cc1 directly for ps4 and don't specify any of the
two options?
seaneveson added a comment.
Ping.
https://reviews.llvm.org/D40712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
seaneveson marked an inline comment as done.
seaneveson added a comment.
In https://reviews.llvm.org/D40712#949979, @MatzeB wrote:
> I also wonder whether it would be possible to move the fact that it defaults
> to on for PS4 into the PS4CPU.cpp file somehow (not that things are
> distributed t
seaneveson updated this revision to Diff 126350.
seaneveson added a comment.
Improve tests.
https://reviews.llvm.org/D40712
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/Compile
