[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is no longer needed after D57670 landed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40816/new/

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek added a comment. After some more digging through libc++ test suite, I think I understand now why these are different variables. It may be possible to remove these and just rely on plain CMake variables but this is likely going to require some more CMake and lit surgery, so for now I'm go

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I'm okay with this change in principle, but Im worried that this may break the buildbots. Please ensure that they remain green after this change. Repository: rL LLVM https://reviews.l

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. I think just remove it from them. Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek added a comment. Actually it seems to be missing in libunwind, but I see it in libc++abi and libc++ (I missed that one). Do you want me to remove it from those two or add it to libunwind? It's a little strange to be using both `LIBUNWIND_TARGET_TRIPLE` and `TARGET_TRIPLE` in the same fil

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. (i.e. you should delete that, since this is the last dependency on it AFAICT) Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. There's a: `set(TARGET_TRIPLE ...)` in each of these runtimes' CMakeLists.txt... Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek created this revision. The variable representing target triple in libunwind is named LIBUNWIND_TARGET_TRIPLE, not TARGET_TRIPLE. Repository: rL LLVM https://reviews.llvm.org/D40816 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in