rwols closed this revision.
rwols added a comment.
https://reviews.llvm.org/D41118 fixes both the start positions as well as the
ranges, let's merge that.
https://reviews.llvm.org/D40860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
sammccall added a comment.
https://reviews.llvm.org/D41118 adds real (non-empty) ranges for diagnostics.
I've copied all the changes you've made here with some slight tweaks, as they
were required for that too.
If you like it as-is, probably easiest to land that instead.
But I'm also happy for y
sammccall added a comment.
Hmm, I looked into the empty diagnostic ranges, and it overlaps here a lot.
Feel free to go ahead and land this and I can merge, otherwise I can include
this fix there.
Regardless of how it gets landed, thanks for finding and fixing this, this
explains a lot of weird
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry for the delay getting this reviewed.
LG, thanks for fixing this! Just style nits.
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:124
+/// Convert a clang::So
rwols created this revision.
This translates diagnostics correctly between 0-based LSP columns, and 1-based
clang columns.
https://reviews.llvm.org/D40860
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/ClangdUnit.cp
