[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2018-05-16 Thread Amara Emerson via Phabricator via cfe-commits
aemerson abandoned this revision. aemerson added a comment. In https://reviews.llvm.org/D40864#1100492, @dexonsmith wrote: > Did this eventually go in? No, this approach was superseded. I will upstream a new implementation in the near future. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2018-05-15 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Did this eventually go in? Repository: rC Clang https://reviews.llvm.org/D40864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2017-12-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:442 Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning(); + Options.EnableStackProbe = CodeGenOpts.StackProbe; aemerson wrote: > ahatanak wrote: > > Is there a reason you can't use

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2017-12-06 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:442 Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning(); + Options.EnableStackProbe = CodeGenOpts.StackProbe; ahatanak wrote: > Is there a reason you can't use function attributes

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2017-12-05 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:442 Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning(); + Options.EnableStackProbe = CodeGenOpts.StackProbe; Is there a reason you can't use function attributes "probe-stack"="__

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2017-12-05 Thread Gerolf Hoflehner via Phabricator via cfe-commits
Gerolf added reviewers: dexonsmith, ahatanak, MatzeB. Gerolf added a comment. It looks pretty straightforward, but I'd ask (at least) Duncan or Akira, and Matthias to review this more carefully. -Gerolf Repository: rC Clang https://reviews.llvm.org/D40864

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

2017-12-05 Thread Amara Emerson via Phabricator via cfe-commits
aemerson created this revision. Add a new -mstack-probe and -mno-stack-probe option to enable the generation of stack probing functions on non-Windows platforms, if supported. This patch only enables this for Darwin. Repository: rC Clang https://reviews.llvm.org/D40864 Files: include/cla