sammccall created this revision.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
This improves readability of tests and error messages.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40952
Files:
test/clangd/completion-items-kinds.test
test/clangd/completion-p
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: unittests/clangd/CodeCompleteTests.cpp:289
+};
+void Foo::pub() { this->^ }
+ )cpp");
The `^` symbol conflicts with t
ioeric accepted this revision.
ioeric added a comment.
lg
Comment at: unittests/clangd/Matchers.h:54
+ bool MatchAndExplain(const std::vector &V,
+ ::testing::MatchResultListener *L) const {
+std::vector Matches(Matchers.size());
`ove
sammccall updated this revision to Diff 126114.
sammccall marked an inline comment as done.
sammccall added a comment.
Reformat around code-complete testcases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40952
Files:
test/clangd/completion-items-kinds.test
test/clangd/com
sammccall updated this revision to Diff 126116.
sammccall added a comment.
Add documentation to matcher implementation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40952
Files:
test/clangd/completion-items-kinds.test
test/clangd/completion-priorities.test
test/clangd/c
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:289
+};
+void Foo::pub() { this->^ }
+ )cpp");
ilya-biryukov wrote:
> The `^` symbol conflicts with the corresponding operator
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320148: [clangd] Convert lit code completion tests to
unit-tests. NFC (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D40952
Files:
clang-tools-extra/trunk/test/clangd/completi
