a.sidorin added a comment.
Hi Alexey,
This commit strongly needs testing on some real code. I cannot predict the TP
rate of this checker now.
Regarding implementation, you can find some remarks inline.
Comment at: lib/StaticAnalyzer/Checkers/CallArgsOrderChecker.cpp:31
+
+cla
alexfh added a comment.
In https://reviews.llvm.org/D41077#958819, @szepet wrote:
> 4. FYI: There is a similar check under review which uses only the AST
> provided information and implemented as a tidy-checker:
> https://reviews.llvm.org/D20689 (As I see your checker does not uses symbolic
>
szepet added subscribers: alexfh, szepet.
szepet requested changes to this revision.
szepet edited reviewers, added: xazax.hun, szepet; removed: dergachev.a.
szepet added a comment.
Herald added a subscriber: rnkovacs.
Hi Alexey!
Thank you for working on this!
Some general comments on the patch:
anna resigned from this revision.
anna added a comment.
Perhaps added me incorrectly as reviewer?
Repository:
rC Clang
https://reviews.llvm.org/D41077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
alexey.knyshev created this revision.
alexey.knyshev added a project: clang.
Herald added a subscriber: mgorny.
CallArgsOrderChecker which looks for accidental swap or skip of arguments in
function, methods, constructors and operators calls
Repository:
rC Clang
https://reviews.llvm.org/D4107
