[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: wangpc. Herald added a project: All. Is this still relevant or can we close this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41145/new/ https://reviews.llvm.org/D41145 ___ cfe-commits

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2017-12-13 Thread Mark Lodato via Phabricator via cfe-commits
lodato added a comment. Oops! Fixed. Thanks for catching this! https://reviews.llvm.org/D41145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2017-12-13 Thread Mark Lodato via Phabricator via cfe-commits
lodato updated this revision to Diff 126792. lodato added a comment. Re-add check for `len(commits) > 2`. https://reviews.llvm.org/D41145 Files: google3/third_party/llvm/llvm/tools/clang/tools/clang-format/git-clang-format Index:

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2017-12-13 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: google3/third_party/llvm/llvm/tools/clang/tools/clang-format/git-clang-format:252 + assert len(commits) != 0 + if len(commits) >= 2: +return

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato created this revision. lodato added reviewers: djasper, klimek, Alexander-Shukaev. The only user-visible change is rewriting of the --help message to make the different modes more clear. Internally, this is a significant refactoring to make the source and destination of the diff to be